Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @padenot currently on macOS the rust libs don't get built.
This is an attempt to download the rust libs and build them in build.rs according to: https://github.com/mozilla/cubeb-coreaudio-rs/blob/trailblazer/build-audiounit-rust-in-cubeb.sh
You have to add an empty
[workspace]
after the first build attempt tocubeb-sys/libcubeb/src/cubeb-coreaudio-rs/Cargo.toml
because it needs be disconnected to the main workspace.Then the libs get correctly build in
cubeb-sys/libcubeb/src/cubeb-coreaudio-rs/target/release/libcubeb_coreaudio.a
andcubeb-sys/libcubeb/src/cubeb-coreaudio-rs/target/debug/libcubeb_coreaudio.a
where the CMake script of cubeb should be looking for it according to CMakeScript line 363.The linking fails anyways with
Any ideas for a different strategy?