Cross-compile for aarch64-linux. #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this build currently fails due to the bug I mentioned, but #97 fixes the build. |
This architecture has a different c_char: u8, rather than i8. Due to rust-lang/rust#113735, this causes a build breakage, since CStr::from_ptr was documented to take an i8 but actually takes a c_char.
mutexlox-signal
force-pushed
the
mutexlox/build-arm64-linux
branch
from
e844dc1
to
6266616
Compare
|
rebased, this should pass now. |
|
Other than the new nightly clippy issues, |
|
Perhaps we can just build the library and not systest for now, and address that in a future PR? |
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This architecture has a different c_char: u8, rather than i8.
Due to rust-lang/rust#113735, this causes a build breakage, since CStr::from_ptr was documented to take an i8 but actually takes a c_char.