audiounit: use one instance of audiounit on duplex stream (Bug 1404969) #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please have a look at the travis failure, it looks serious. |
|
The new push is just for testing. I'll tell when is ready. |
achronop
force-pushed
the
osx-remove-input-unit
branch
from
8f63644
to
467809e
Compare
achronop
changed the title
|
This is ready now. You can go on and review. When review is done please do not merge. If we are late in the release cycle at that point I would like to wait the next one. Also I would like to import it as a single commit. |
padenot
approved these changes
Nov 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AudioUnit can be configured for duplex operation when both device ids are the same for input and output. This is always the case since we configure an aggregate device on duplex stream. This patch remove the input AU and makes use of the same AU for input and output. A side effect on the positive side is that switching become cheaper.