Skip to content
This repository has been archived by the owner on May 27, 2021. It is now read-only.

eslint things for real #84

Merged
merged 2 commits into from
Apr 5, 2018
Merged

eslint things for real #84

merged 2 commits into from
Apr 5, 2018

Conversation

magopian
Copy link
Contributor

@magopian magopian commented Apr 5, 2018 •
edited
Loading

Fixes #79

I didn't realize in #75 that prettier-eslint is only useful to fix things, not to warn about things. So now we need to run eslint twice. Sad panda.

To review
Pull, run yarn lint, check out package.json

andymikulski
andymikulski approved these changes Apr 5, 2018
View reviewed changes
Copy link
Contributor

@andymikulski andymikulski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@andymikulski andymikulski merged commit d2eaf52 into mozilla:master Apr 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andymikulski andymikulski andymikulski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prettier-eslint isn't eslint'ing the things
2 participants
@magopian @andymikulski