Skip to content
This repository has been archived by the owner on Jun 30, 2018. It is now read-only.

default browser status: x-axis label rounding error #155

Open
bcolloran opened this issue Dec 8, 2016 · 2 comments
Open

default browser status: x-axis label rounding error #155

bcolloran opened this issue Dec 8, 2016 · 2 comments
Assignees
Milestone

Comments

@bcolloran
Copy link

bcolloran commented Dec 8, 2016

on this view: https://moz-distribution-viewer.herokuapp.com/chart/13/

the x-axis labels are (0,1,1); should be [0, 0.5, 1] -- or actually ideally percentages [0%, 50%, 100%] to match the "This shows the default status of each FF client as a percentage of time; most clients have FF set as default either 0% or 100% of the time, but some clients switch default status."

@rafrombrc rafrombrc added the ready label Mar 7, 2017
@rafrombrc rafrombrc added this to the m2 milestone Mar 7, 2017
@openjck
Copy link
Contributor

openjck commented Mar 17, 2017

Just as a note to self, this also happens in metrics-graphics:

metricsgraphics/metrics-graphics#707

@openjck
Copy link
Contributor

openjck commented Mar 17, 2017

Note that #221 will address many of the cases where this could happen but not all of them. It would be better to choose how many significant digits should be shown on a chart-by-chart basis. d3 has precisionRound and friends for this, but it'll take some thought to figure out how to best find the step.

Let's leave this open even after #221 lands and I can follow it up with an even more general fix.

spasovski added a commit that referenced this issue Mar 28, 2017
Issue #155: Don't round labels to nearest digit
@rafrombrc rafrombrc modified the milestones: m3, m2 Mar 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants