Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak configuration docs #146

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Tweak configuration docs #146

merged 1 commit into from
Jul 28, 2021

Conversation

jaap3
Copy link
Contributor

@jaap3 jaap3 commented Mar 3, 2020

  • Change formatting and some wording for readability sake
  • Make defaults reflect the actual default values

@jaap3
Copy link
Contributor Author

jaap3 commented Mar 17, 2020

@EnTeQuAk could you please take a look at this? Thanks!

@g-k
Copy link
Contributor

g-k commented Jul 26, 2021

This lgtm on first pass. @jaap3 can you rebase this PR? Thanks!

@jaap3
Copy link
Contributor Author

jaap3 commented Jul 27, 2021

@g-k I've rebased and fixed some minor spelling issues while I was at it, please take a look. Thanks!

jaap3
jaap3 commented Jul 27, 2021
View reviewed changes
docs/configuration.rst Outdated Show resolved Hide resolved
docs/configuration.rst Show resolved Hide resolved
docs/configuration.rst Outdated Show resolved Hide resolved
docs/configuration.rst Outdated Show resolved Hide resolved
docs/configuration.rst Outdated Show resolved Hide resolved
docs/configuration.rst Outdated Show resolved Hide resolved
docs/configuration.rst Outdated Show resolved Hide resolved
docs/configuration.rst Outdated Show resolved Hide resolved
@jaap3 jaap3 force-pushed the patch-1 branch 3 times, most recently from 13d45b5 to 517738e Compare July 27, 2021 11:32
g-k
g-k suggested changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@g-k g-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for rebasing! I took a more detailed look and have a couple nitpicks, but it looks good overall.

docs/configuration.rst

.. _Content-Security-Policy: http://www.w3.org/TR/CSP/
.. _Content-Security-Policy: https://www.w3.org/TR/CSP/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

docs/configuration.rst
``CSP_REPORT_TO``
Set the ``report-to`` directive. A string describing a reporting group. *None*
Note: This doesn't use default-src as a fall-back.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this isn't a src list so we can remove this comment about the fallback

docs/configuration.rst Show resolved Hide resolved
docs/configuration.rst Outdated Show resolved Hide resolved
@jaap3
Tweak configuration docs
6335cbe 
* Change formatting and some wording for readability sake
* Make defaults reflect the actual default values
* Fix some typos
g-k
g-k approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@g-k g-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thank you!

@g-k g-k merged commit 2f8c777 into mozilla:main Jul 28, 2021
@jaap3 jaap3 deleted the patch-1 branch July 28, 2021 17:23
@data-sync-user data-sync-user mentioned this pull request Jun 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-k g-k g-k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaap3 @g-k