Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Dockerfile to end up in the right place while installing imports and then running data val job #81

Merged
merged 2 commits into from
Sep 12, 2022

Conversation

chelseatroy
Copy link
Contributor

Why we're CDing twice:

  1. We need to be in app/ to install the dependencies
  2. Then we need to be in app/src/ to run the script itself

1. We need to be in app/ to install the dependencies
2. Then we need to be in app/src/ to run the script itself
@chelseatroy chelseatroy changed the title Adjust Dockerfil to end up in the right place while installing imports and then running data val job Adjust Dockerfile to end up in the right place while installing imports and then running data val job Sep 12, 2022
…ppropriate location in telemetry-airflow to run the job instead
Copy link
Contributor

@perrymcmanis144 perrymcmanis144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm, I think this strategy is the correct one at this point

@perrymcmanis144 perrymcmanis144 merged commit 88f5e3f into main Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants