feat(project): Retrieve metric-hub segments in Experimenter #11243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RJAK11
force-pushed
the
retrieve-segments-11242
branch
from
9e53fa7
to
bea1278
Compare
Because
*Experimenter needs to retrieve the segments from metric-hub as they are currently not available there
This commit
*allows Experimenter to retrieve segments from metric-hub
Fixes #11242
RJAK11
force-pushed
the
retrieve-segments-11242
branch
from
bea1278
to
7da18b5
Compare
mikewilli
reviewed
Aug 28, 2024
| @@ -530,6 +530,14 @@ | |||
| BASE_DIR / "outcomes" / "metric-hub-main" / "jetstream" / "outcomes" | |||
| ) | |||
|
|
|||
| JETSTREAM_CONFIG_SEGMENTS_PATH = ( | |||
There was a problem hiding this comment.
So the JETSTREAM_CONFIG part of the other name is actually a relic of pre-metric-hub config repo, which was called jetstream-config. Maybe it's time to update these settings to say METRIC_HUB_ instead of JETSTREAM_CONFIG_? This would make all three of these related settings consistent, and update them for the new repo.
Something like:
METRIC_HUB_OUTCOMES_PATHMETRIC_HUB_SEGMENTS_PATH_DEFAULTMETRIC_HUB_SEGMENTS_PATH_JETSTREAM
RJAK11
force-pushed
the
retrieve-segments-11242
branch
2 times, most recently
from
4d7d496
to
aca427b
Compare
RJAK11
requested review from
jaredlockhart,
yashikakhurana and
brennie
as code owners
RJAK11
force-pushed
the
retrieve-segments-11242
branch
from
12f50d0
to
7da18b5
Compare
mikewilli
requested changes
Aug 30, 2024
...imenter/experimenter/segments/tests/fixtures/valid_segments_definitions/firefox_desktop.toml
Outdated
Show resolved
Hide resolved
Because
*Experimenter needs to retrieve the segments from metric-hub as they are currently not available there
This commit
*allows Experimenter to retrieve segments from metric-hub
Fixes #11242
This was referenced Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This commit
Fixes #11242