Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make total stats order consistent with alias stats #1098

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

Vinnl
Copy link
Collaborator

@Vinnl Vinnl commented Sep 13, 2021

Fixes #1094.

In other words, Blocked comes before Forwarded in both the stats at
the top of the page as well as in the stats to the right of a
single alias. They're in the same order in the designs.

Before:

image

After:

image

In other words, Blocked comes before Forwarded in both the stats at
the top of the page as well as in the stats to the right of a
single alias.
@Vinnl Vinnl requested a review from maxxcrawford September 13, 2021 10:13
Copy link
Contributor

@maxxcrawford maxxcrawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔁 Nice one!

@maxxcrawford maxxcrawford merged commit a9d487d into main Sep 13, 2021
@maxxcrawford maxxcrawford deleted the 1094-stats-order branch September 13, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The overall consistency of the order in which forwarded and blocked emails are displayed could be improved
2 participants