Remove "Copied!" tooltip after it's hidden #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Where the "Copied!" tooltip would previously only be removed when another alias was copied, it is now removed as soon as it's hidden from view. This prevents the animation from being replayed every time the alias is hidden from view, then shown again (i.e. when a filter is applied, then unapplied).
maxxcrawford
approved these changes
Sep 13, 2021
| // is applied and removed again). | ||
| triggeringEl.classList.remove("alias-copied", "alias-copied-fadeout"); | ||
| triggeringEl.title = "Copy alias to clipboard"; | ||
| }, 4 * 1000); |
There was a problem hiding this comment.
Nice readability math here!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1099.
Where the "Copied!" tooltip would previously only be removed when
another alias was copied, it is now removed as soon as it's hidden
from view. This prevents the animation from being replayed every
time the alias is hidden from view, then shown again (i.e. when a
filter is applied, then unapplied).