Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GitHub name rather than logo #1525

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Use GitHub name rather than logo #1525

merged 1 commit into from
Feb 11, 2022

Conversation

Vinnl
Copy link
Collaborator

@Vinnl Vinnl commented Feb 10, 2022

image

How to test: check that there is no GitHub logo in the footer.

  • l10n dependencies have been merged, if any. (It's a name, so not translated.)
  • I've added a unit test to test for potential regressions of this bug (or this is a front-end change, where we don't yet have unit test infrastructure).
  • All UI revisions follow the coding standards, and use Protocol tokens where applicable (see /static/scss/libs/protocol/css/includes/tokens/dist/index.scss).
  • Commits in this PR are minimal and have descriptive commit messages.

@Vinnl Vinnl requested a review from codemist February 10, 2022 11:50
@Vinnl Vinnl self-assigned this Feb 10, 2022
codemist
codemist approved these changes Feb 10, 2022
View reviewed changes
Copy link
Collaborator

@codemist codemist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP logo

@Vinnl Vinnl requested a review from groovecoder February 11, 2022 09:58
@groovecoder groovecoder merged commit bd405c5 into main Feb 11, 2022
@groovecoder groovecoder deleted the github-name branch February 11, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@groovecoder groovecoder groovecoder approved these changes

@codemist codemist codemist approved these changes

Assignees

@Vinnl Vinnl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vinnl @groovecoder @codemist