-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide CSAT by default #1566
Hide CSAT by default #1566
Conversation
0b41cb9
to
96a6b74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with a known merge conflict incoming.
If you need to land this before #1545, please add that pesky ?
.
static/js/analytics.js
Outdated
return; | ||
} | ||
csatWrapperEl.classList.add("is-visible"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue: I ran into a bug while testing another PR and added a fix in this commit: 98157cb
Suggestion: We will need to port this over/resolve a merge conflict at some point soon.
csatWrapperEl.classList.add("is-visible"); | |
csatWrapperEl?.classList.add("is-visible"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That merge conflict should be fairly easy to resolve, no? 5de9430
Only display the CSAT if the script to handle its interactions was properly loaded (i.e. not blocked by an adblocker).
5de9430
to
6cd2e39
Compare
Um. I'm not entirely sure how this GitHub thing works, apologies if I'm being premature with this feedback: Has the issue of this non-working banner been fixed, or is there more to do? Because I'm still seeing it (it still doesn't work): Notes:
... and it appears if I enable it: Reversed logic somewhere? Or simply a continuation of the grudge against the British Empire (as was)? ;) |
Sorry @pendantry, the fix has been accepted into the main codebase, but it hasn't been published to the main website yet. I believe that when we publish to the main website, that is announced here, but in any case it should land soon-ish. |
This PR fixes #1564.
Only display the CSAT if the script to handle its interactions was
properly loaded (i.e. not blocked by an adblocker).
How to test: Make sure your browser language is set to
en-US
, is in the US, you don't haveRECRUITMENT_BANNER_*
env vars set, and you're logged in to an account that has had Premium for at least seven days. (Alternatively, addor True
to line 21 ofheader.html
.) You should see the CSAT banner.Now install/enable an adblocker. You should no longer see the banner. (Whereas before, it would be visible but just not work.)
/static/scss/libs/protocol/css/includes/tokens/dist/index.scss
).