Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPP-3616 Initial removal of banners we no longer need #4179

Merged
merged 8 commits into from
Dec 13, 2023
Merged

MPP-3616 Initial removal of banners we no longer need #4179

merged 8 commits into from
Dec 13, 2023

Conversation

lloan
Copy link
Contributor

@lloan lloan commented Nov 30, 2023

This PR fixes MPP-3616

New feature description

This PR removes many banners.

Screenshot (if applicable)

Following banners removed:

image

How to test

Visit profile and make sure these banners do not show up anymore.

Checklist (Definition of Done)

  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • I've added or updated relevant docs in the docs/ directory
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.
  • All UI revisions follow the coding standards, and use Protocol tokens where applicable (see /frontend/src/styles/tokens.scss).
  • Commits in this PR are minimal and have descriptive commit messages.
  • l10n changes have been submitted to the l10n repository, if any.

@lloan lloan self-assigned this Nov 30, 2023
Copy link
Member

@groovecoder groovecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good; I love removing code!

All the top banners are gone. There are still some lower/footer banners. I assume those are okay to keep?

image

@lloan
Copy link
Contributor Author

lloan commented Dec 4, 2023

Code looks good; I love removing code!

All the top banners are gone. There are still some lower/footer banners. I assume those are okay to keep?

image

Correct. All that is blocking me here is the test coverage threshold - its at like 49% out of 50% required. So its failing. I have to write tests to increase that coverage.

@lloan lloan added this pull request to the merge queue Dec 5, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 5, 2023
@lloan lloan added this pull request to the merge queue Dec 5, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 5, 2023
@lloan lloan added this pull request to the merge queue Dec 7, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 7, 2023
@lloan lloan added this pull request to the merge queue Dec 7, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 7, 2023
@lloan lloan added this pull request to the merge queue Dec 13, 2023
Merged via the queue into main with commit 8935da2 Dec 13, 2023
7 checks passed
@lloan lloan deleted the MPP-3616 branch December 13, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants