Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPP-3623 4-mask upsell pop-up for Free Relay users #4225

Merged
merged 3 commits into from
Dec 20, 2023
Merged

MPP-3623 4-mask upsell pop-up for Free Relay users #4225

merged 3 commits into from
Dec 20, 2023

Conversation

lloan
Copy link
Contributor

@lloan lloan commented Dec 15, 2023

This PR fixes MPP-3626

L10N: mozilla-l10n/fx-private-relay-l10n#167

New feature description

Confirmed: Implementation of the corner pop-up when free relay user hits that limit – this will appear on the dashboard

  • Corner popup that shows up when a user hits their 4th mask. Goes away once dismissed.

  • This only shows up for free users

  • There is a specific image and messaging provided for regions where phone plans are available and where only emails are available. US & Non US

  • This is behind a feature flag: four_mask_limit_upsell

  • See spec in figma: How to upsell 5 mask limit

Screenshot (if applicable)

image

How to test

  • four_mask_limit_upsell flag should be turned on
  • must use a free account
  • must have 4 masks set

Checklist (Definition of Done)

  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • I've added or updated relevant docs in the docs/ directory
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.
  • All UI revisions follow the coding standards, and use Protocol tokens where applicable (see /frontend/src/styles/tokens.scss).
  • Commits in this PR are minimal and have descriptive commit messages.
  • l10n changes have been submitted to the l10n repository, if any.

@lloan lloan self-assigned this Dec 15, 2023
@lloan lloan requested a review from rafeerahman December 15, 2023 20:15
Copy link
Contributor

@rafeerahman rafeerahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, was there a PR in L10n for the strings?

@lloan
Copy link
Contributor Author

lloan commented Dec 20, 2023

@rafeerahman updated ticket with l10n PR.

@lloan lloan added this pull request to the merge queue Dec 20, 2023
Merged via the queue into main with commit 5efd6e6 Dec 20, 2023
8 checks passed
@lloan lloan deleted the MPP-3623 branch December 20, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants