MPP-3390: Update django-allauth to 0.60.0 #4246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwhitlock
force-pushed
the
update-django-allauth-mpp-3390
branch
from
c5f6e42 to
17fed21
Compare
jwhitlock
force-pushed
the
update-django-allauth-mpp-3390
branch
from
17fed21 to
f9306da
Compare
jwhitlock
changed the title
|
Force-push to rebase and add 0.60.0 update. |
jwhitlock
force-pushed
the
update-django-allauth-mpp-3390
branch
from
f9306da to
ac63fa0
Compare
All historical accounts that arrived from FxA have emails that were verified before the Relay account was created. Before django-allauth 0.55.0, Relay ignored email verification.
With this update, a provider that has a database-backed SocialApp (for example, for OpenID client credentials) needs to be initialized with that SocialApp. Switch to using the socialaccount app adapter to load the FirefoxAccountProvider, and setup the SocialApp in tests. With this update, non-null provider_id and settings fields are added to the socialaccount_socialapp table. This is OK as long as a new social app is not added during a database migration. For Relay testing, add a migration with default values.
This release requires a new allauth middleware
We added indexes on upper(email) for the account_emailaddress and auth_user tables. The upper(email) index for account_emailaddress was also added by django-allauth in 0.56.0. This migration removes Relay's copy of that index.
jwhitlock
force-pushed
the
update-django-allauth-mpp-3390
branch
from
ac63fa0 to
e496846
Compare
|
With PR #4177 merged, this is ready for review. |
groovecoder
requested changes
Jan 9, 2024
jwhitlock
commented
Jan 9, 2024
There was a problem hiding this comment.
Thanks @groovecoder. I've made the suggested test changes and answered some questions about the migrations.
groovecoder
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates django-allauth from 0.54.0 to 0.59.0 for MPP-3390.
Changes needed for upgrades:
provider_idandsettings, were added tosocialaccount_socialappto support OpenID providers in the Django admin. These are both non-nullable with Django-level defaults. A new migration adds database-level defaults for our migration tests.terms_accepted_view, which was manually creating aFirefoxAccountsProviderin order to create a new account.SocialAppis now needed for some tests which previously did not need them.requestin a global context, so the code doesn't need to pass it around as much.