-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
for MPP-3567: add last_engagement field to Profile model #4277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b22b424
to
1a83021
Compare
Update the field with datetime.now() for each engagement action.
1a83021
to
24cad80
Compare
ff6e037
to
e93d705
Compare
jwhitlock
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @groovecoder! This looks good, no suggested code changes, but some questions about the design and some nits.
Questions answered; nits addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Profile.last_engagement DateTime field
For MPP-3567, we need to update the database to measure new engagement actions. This PR adds a new
last_engagement
field to theProfile
model, and updates it each time one of the new engagement actions happens:RelayAddress
is deletedDomainAddress
is deletedRelayAddress
is addedDomainAddress
is addedHow to test
Checklist (Definition of Done)
/frontend/src/styles/tokens.scss
).