MPP-3687 [Android] Delete mask modal not appearing always

[lloan]

This PR fixes MPP-3687

New feature description

[Android] Delete mask modal not appearing always and deleting the mask immediately. This adds a check so that the onConfirm function checks if the modal is open.

const onConfirm: FormEventHandler = (event) => {
    event.preventDefault();

    if (modalState.isOpen) {
      props.onDelete();
      modalState.close();
    }
  };

Screenshot (if applicable)

Not applicable.

How to test

1. Navigate to the Relay email mask dashboard;
2. Generate a new email mask;
3. Delete the email mask;
4. Repeat steps 2-3 a few times and observe behaviour;

Expected result:

The delete mask modal appears whenever a user tries to delete a mask;

Incorrect result:

Intermittently, the modal does not appear and the mask is deleted instantly;

Checklist (Definition of Done)

• Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
• All acceptance criteria are met.
• Jira ticket has been updated (if needed) to match changes made during the development process.
• I've added or updated relevant docs in the docs/ directory
• Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.
• All UI revisions follow the coding standards, and use Protocol tokens where applicable (see /frontend/src/styles/tokens.scss).
• Commits in this PR are minimal and have descriptive commit messages.
• l10n changes have been submitted to the l10n repository, if any.

[maxxcrawford]

Nice fix!

Open-ended question for @Vinnl: I wonder if there's a larger refactor on how to handle this without adding the additional check inside the onConfirm event?

[Vinnl]

@maxxcrawford Hmm, I don't think I have enough context to answer. Looking at the change, it sounds like the onConfirm handler was being called while the dialog wasn't open - even though it's a submit handler for a form that's only visible inside the dialog? Presumably, to fix the root cause would require investigating why that callback was being called in the first place.