MPP-3668 collect domain address telemetry #4323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwhitlock
approved these changes
Jan 19, 2024
...grations/0060_add_num_deleted_relay_addresses_and_num_deleted_domain_addresses_to_profile.py
Outdated
Show resolved
Hide resolved
| domain_address = DomainAddress.objects.create( | ||
| user=user_profile.user, | ||
| address=address, | ||
| user=user_profile.user, address=address, first_emailed_at=first_emailed_at |
| @@ -334,6 +334,43 @@ def test_delete_mozmail_deleted_address_object(self): | |||
| deleted_count = DeletedAddress.objects.filter(address_hash=address_hash).count() | |||
| assert deleted_count == 1 | |||
|
|
|||
| def test_delete_increments_values_on_profile(self): | |||
| @@ -314,6 +315,30 @@ def switch_link(key, value): | |||
| return HttpResponse(wrapped_email) | |||
|
|
|||
|
|
|||
| def _store_reply_record( | |||
There was a problem hiding this comment.
👍 better here with the rest of the email processing code. Someday, I'll move it all to emails/processing.py or similar...
| "id" integer NOT NULL PRIMARY KEY AUTOINCREMENT, | ||
| "num_deleted_relay_addresses" integer unsigned NOT NULL CHECK ( | ||
| "num_deleted_relay_addresses" >= 0 | ||
| ) DEFAULT 0, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature description
Collect domain address telemetry for:
Optionally collect data on number of deleted addresses per user
Checklist (Definition of Done)