Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump msw from 2.0.14 to 2.1.5 #4364

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 29, 2024

Bumps msw from 2.0.14 to 2.1.5.

Release notes

Sourced from msw's releases.

v2.1.5 (2024-01-25)

Bug Fixes

  • add "request" to response events (#1993) (bad537f1fce7511f0a7258c0216a9ad49fbc27b8) @​kettanaito
  • does not warn on unhandled "file://" requests (#1997) (5afedb1af6d20f8be4e079f6a22ca617890b3507) @​kettanaito
  • resolve relative fetch urls in jsdom (#1999) (82ab765c44e866310ba9c4cc24fed3d6cfaf7735) @​kettanaito

v2.1.4 (2024-01-23)

Bug Fixes

v2.1.3 (2024-01-22)

Bug Fixes

  • export "getResponse" for batched GraphQL queries (#1982) (42f147367709d85c09ec44eb300848d0bbbf1b6d) @​kettanaito
  • reduce library footprint by avoiding barrel imports (#1987) (b803e26a65fff537332ccfcb0a1a53dc4462659c) @​thepassle

v2.1.2 (2024-01-17)

Bug Fixes

  • export "HttpRequestHandler" and "GraphQLRequestHandler" types (#1973) (ca423d9ffcf940ed9118e65126b5008e355fc2b3) @​kettanaito

v2.1.1 (2024-01-17)

Bug Fixes

  • annotate the "requestId" response resolver argument (#1969) (f22294eb81bb53495265fba777e049a7102c2e1f) @​skvale

v2.1.0 (2024-01-15)

Features

  • up tsconfig target for more modern syntax (#1780) (29182cebaaa5e7acfebcc513e5f84e8723236d27) @​thepassle @​kettanaito
  • add "requestId" as response resolver argument (#1942) (51ab8cc0e31848e82eebc2f3e0cdf280f4a2ef8e) @​skvale @​kettanaito
  • support multiple directories in "msw.workerDirectory" (#1832) (4dbf99ac542b2f2dbca70874d638fb7261d9ffdd) @​kettanaito
  • deprecate "waitUntilReady" (deferNetworkUntil) worker option (#1964) (86a22ac92f77a11c0fd165f1313de1cc8f936f16) @​kettanaito
  • support throwing responses in response resolvers (#1963) (39dc0e64497df448de74fe827fe6f1b4ecdbf5c4) @​kettanaito

Shoutout to @​mattcosta7 for his continuous on the library's performance and stability 🎉

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jan 29, 2024
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/msw-2.1.5 branch from 1138fa4 to c15d0dc Compare January 29, 2024 09:27
@jwhitlock jwhitlock assigned Vinnl and unassigned Vinnl Jan 30, 2024
@jwhitlock
Copy link
Member

@Vinnl had this comment #4339 (comment):

Something appears to be wrong in this version, as I can't use the mock accounts - I end up at a white page, even after refresh.
Weirdly it does work locally :/ I'm going to let this sit for a bit and see if a new patch version comes along without weird issues.

I see a similar issue with the current netlify preview. A log-in works, leads to a blank page, and then the dashboard is visible after a second. A logout leads to a blank screen, and a refresh is needed to see content.

@jwhitlock
Copy link
Member

This msw comment looks promising, trying it out:

mswjs/msw#1981 (comment)

@jwhitlock jwhitlock force-pushed the dependabot/npm_and_yarn/msw-2.1.5 branch from 9638cff to db39586 Compare February 1, 2024 17:50
@jwhitlock
Copy link
Member

That does not work, I still get the blank pages. I do see MSW messages in the console, but the React requests appear to happen before MSW is loaded. I think this is on the right track, but we need to await MSW server and worker initialization before React starts making requests. Hopefully that makes sense to @Vinnl or other JS folks...

@Vinnl
Copy link
Collaborator

Vinnl commented Feb 2, 2024

Thanks @jwhitlock, that just needed a small tweak (db66523), and now it works again - good find! (It's a bit slower to load, but that should only be on the demo site.)

dependabot bot and others added 2 commits February 2, 2024 16:55
Bumps [msw](https://github.com/mswjs/msw) from 2.0.14 to 2.1.5.
- [Release notes](https://github.com/mswjs/msw/releases)
- [Changelog](https://github.com/mswjs/msw/blob/main/CHANGELOG.md)
- [Commits](mswjs/msw@v2.0.14...v2.1.5)

---
updated-dependencies:
- dependency-name: msw
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Vincent <git@vincenttunru.com>
@Vinnl Vinnl force-pushed the dependabot/npm_and_yarn/msw-2.1.5 branch from db66523 to a03b0e1 Compare February 2, 2024 15:56
@Vinnl Vinnl requested a review from jwhitlock February 2, 2024 15:57
Copy link
Member

@jwhitlock jwhitlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝 Thanks @Vinnl, this makes sense, and would have taken me a long time to get right.

@Vinnl Vinnl added this pull request to the merge queue Feb 2, 2024
Merged via the queue into main with commit 48a19c4 Feb 2, 2024
27 checks passed
@Vinnl Vinnl deleted the dependabot/npm_and_yarn/msw-2.1.5 branch February 2, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants