-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump msw from 2.0.14 to 2.1.5 #4364
Conversation
1138fa4
to
c15d0dc
Compare
@Vinnl had this comment #4339 (comment):
I see a similar issue with the current netlify preview. A log-in works, leads to a blank page, and then the dashboard is visible after a second. A logout leads to a blank screen, and a refresh is needed to see content. |
This msw comment looks promising, trying it out: |
9638cff
to
db39586
Compare
That does not work, I still get the blank pages. I do see MSW messages in the console, but the React requests appear to happen before MSW is loaded. I think this is on the right track, but we need to await MSW server and worker initialization before React starts making requests. Hopefully that makes sense to @Vinnl or other JS folks... |
Thanks @jwhitlock, that just needed a small tweak (db66523), and now it works again - good find! (It's a bit slower to load, but that should only be on the demo site.) |
Bumps [msw](https://github.com/mswjs/msw) from 2.0.14 to 2.1.5. - [Release notes](https://github.com/mswjs/msw/releases) - [Changelog](https://github.com/mswjs/msw/blob/main/CHANGELOG.md) - [Commits](mswjs/msw@v2.0.14...v2.1.5) --- updated-dependencies: - dependency-name: msw dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Vincent <git@vincenttunru.com>
db66523
to
a03b0e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤝 Thanks @Vinnl, this makes sense, and would have taken me a long time to get right.
Bumps msw from 2.0.14 to 2.1.5.
Release notes
Sourced from msw's releases.
Commits
fd70e10
chore(release): v2.1.514a0b92
chore(deps-dev): bump vite from 4.5.0 to 5.0.12 (#1979)b5918a1
chore: run vitest in watch mode in dev (#1998)bad537f
fix: add "request" to response events (#1993)5afedb1
fix: does not warn on unhandled "file://" requests (#1997)82ab765
fix: resolve relative fetch urls in jsdom (#1999)17bf9fc
test: add request formdata file size test (#1995)396b12f
chore(release): v2.1.41cbf615
fix: bundle browser build (#1988)bc0bea6
fix: removes request parsing from "onUnhandledRequest" (#1990)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major version
will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor version
will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>
will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>
will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>
will remove the ignore condition of the specified dependency and ignore conditions