MPP-79: Add ruff Python linter
#4607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
groovecoder
approved these changes
Apr 20, 2024
|
|
||
| [tool.ruff.lint] | ||
| ignore = [ | ||
| # TODO MPP-3802: Enable more bandit security checks |
The remaining rules check line length and for trailing spaces
`ruff` isort is mostly compatible with `isort`, with one exception in emails/policy.py The check for changes in privaterelay/glean/server_events.py now includes running `ruff check --fix --ignore E501`.
Ignore two rules with production code changes, for now.
jwhitlock
force-pushed
the
add-ruff-again-mpp-79
branch
from
bf8d2e7
to
50826c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ruff tool as a Python linter. I've enabled a few rules, but there are plenty more we could add if we find they would fix issues or flag issues from code review.
This PR fixes #162.
How to test:
pip install -r requirementsruff check .ruff check --select RET .