Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the typing-stubs group with 2 updates #4672

Merged
merged 4 commits into from
May 6, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 6, 2024

Bumps the typing-stubs group with 2 updates: django-stubs and djangorestframework-stubs.

Updates django-stubs from 4.2.6 to 5.0.0

Commits

Updates djangorestframework-stubs from 3.14.4 to 3.15.0

Release notes

Sourced from djangorestframework-stubs's releases.

3.15.0

djangorestframework 3.15 support

Stubs changes

Housekeeping

New Contributors

... (truncated)

Commits
  • 6e22a6f Version 3.15.0 release (#605)
  • 8869eef [pre-commit.ci] pre-commit autoupdate (#604)
  • b882896 Bump pytest from 8.1.1 to 8.2.0 (#603)
  • e00d4ce Allow None for ListField.min/max_length (#601)
  • f141057 Update mypy requirement from <1.10,>=1.7 to >=1.7,<1.11 (#598)
  • f0c9e31 [pre-commit.ci] pre-commit autoupdate (#594)
  • a472d34 CI: Run tests daily to detect incompatible django-stubs changes (#519)
  • e0ec43f Fix HyperlinkedRelatedField.get_object() argument types (#597)
  • 9d25503 Make HyperlinkedModelSerializer generic (#595)
  • 71a6b53 Fix CI: suppress mypy errors in test suite that come from 3rd party packages ...
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels May 6, 2024
@dependabot dependabot bot force-pushed the dependabot/pip/typing-stubs-fb7bf05f94 branch 2 times, most recently from 3aebdfc to 271298e Compare May 6, 2024 14:06
dependabot bot and others added 4 commits May 6, 2024 10:47
Bumps the typing-stubs group with 2 updates: [django-stubs](https://github.com/typeddjango/django-stubs) and [djangorestframework-stubs](https://github.com/typeddjango/djangorestframework-stubs).


Updates `django-stubs` from 4.2.6 to 5.0.0
- [Release notes](https://github.com/typeddjango/django-stubs/releases)
- [Commits](typeddjango/django-stubs@4.2.6...5.0.0)

Updates `djangorestframework-stubs` from 3.14.4 to 3.15.0
- [Release notes](https://github.com/typeddjango/djangorestframework-stubs/releases)
- [Commits](typeddjango/djangorestframework-stubs@3.14.4...3.15.0)

---
updated-dependencies:
- dependency-name: django-stubs
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: typing-stubs
- dependency-name: djangorestframework-stubs
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: typing-stubs
...

Signed-off-by: dependabot[bot] <support@github.com>
django-stubs 5.0.0 has type hints for Django 5.0. We can support the new
signature without using it.
@jwhitlock jwhitlock force-pushed the dependabot/pip/typing-stubs-fb7bf05f94 branch from 271298e to 91f9f1e Compare May 6, 2024 16:04
Copy link
Member

@jwhitlock jwhitlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

django-stubs 4.2.7 to 5.0 updates the version compatibility:

  • Mypy 1.7.x to 1.10.x
  • Django 4.2 to 5.0
  • Django partial support drops 3.2, adds 4.2
  • No change in Python support, still supports 3.8 to 3.12

One of the Django 5.0 change is:

The force_insert argument of Model.save() now allows specifying a tuple of parent classes that must be forced to be inserted.

We don't use multi-table inheritance, so the change is just to our save signatures.

There is also some breakage from PR 4664, requiring some more type annotations.

And, my local ruff is raising warning "UP031 Use format specifiers instead of percent format". I enabled the auto-fix and checked the results. One fixed line was now too long, so I broke it up.

@jwhitlock jwhitlock added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit 3336a5b May 6, 2024
28 checks passed
@jwhitlock jwhitlock deleted the dependabot/pip/typing-stubs-fb7bf05f94 branch May 6, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant