MPP-3927: Pre-fetch profile for domain address #5179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API for domain address uses the subdomain on the Profile to construct the full domain address. Previously, this required 1 query to get all the domain addresses, then 2 queries _per address_ to get the subdomain. So, a user with 100 domain addresses would use 201 queries to get their list of addresses when they visited the dashboard. With this change, the user and profile query is done once, so a user needs 1 query if they have no domain addresses, and 3 total queries for any number of domain addresses. The relay addresses API does not use user or profile data, so it continues to use 1 query for any number of addresses.
|
Looking into the test failures |
|
Figured it out. The |
groovecoder
approved these changes
Nov 11, 2024
api/tests/emails_views_tests.py
Outdated
| Second query: {"sql": "SELECT id, ..."}A | ||
| """ | ||
|
|
||
| # The sqlcommenter middleware records queries twice for sqlite |
There was a problem hiding this comment.
suggestion (non-blocking): this comment is redundant after the doc-block above
Suggested change
| # The sqlcommenter middleware records queries twice for sqlite | |
| # The sqlcommenter middleware records queries twice for sqlite |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API for domain address uses the subdomain on the Profile to construct the full domain address. Previously, this required 1 query to get all the domain addresses, then 2 queries per address to get the subdomain. So, a user with 100 domain addresses would use 201 queries to get their list of addresses when they visited the dashboard. This may contribute to some users getting a 30 second timeout when viewing the dashboard.
With this change, the user and profile query is done once, so a user needs 1 query if they have no domain addresses, and 3 total queries for any number of domain addresses.
The relay addresses API does not use user or profile data, so it continues to use 1 query for any number of addresses.
How to test: