Skip to content

Commit

Permalink
fix(content): Add header and subheader styling where missing
Browse files Browse the repository at this point in the history
Because:

* Some headings were not styled on backbone pages

This commit:

* Add card-header and card-subheader styles where missing in ready, supp_wait_for_auth, auth_wait_for_supp, completed mustache templates

Closes #FXA-8585
  • Loading branch information
vpomerleau committed Nov 8, 2023
1 parent 320c6c1 commit e490811
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 7 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<div id="main-content" class="card pair-auth">
<header>
<h1 id="fxa-pair-auth-wait-for-supp-header">
{{#unsafeTranslate}}Approval now required <small>from your other device</small>{{/unsafeTranslate}}
<h1 id="fxa-pair-auth-wait-for-supp-header" class="card-header">
{{#unsafeTranslate}}Approval now required <small class="card-subheader">from your other device</small>{{/unsafeTranslate}}

This comment has been minimized.

Copy link
@bcolsson

bcolsson Nov 13, 2023

Contributor

@vpomerleau - One of the localizers for zh-TW is asking if it's safe to ignore the styling tag for this string. The styling would be slightly different but I don't see if its a problem if it works better for their locale. But could you confirm if it's okay/safe for this particular string?

</h1>
</header>

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<div id="main-content" class="card">
<header>
<h1 id="fxa-pair-supp-wait-for-auth-header">
{{#unsafeTranslate}}Approval now required <small>from your other device</small>{{/unsafeTranslate}}
<h1 id="fxa-pair-supp-wait-for-auth-header" class="card-header">
{{#unsafeTranslate}}Approval now required <small class="card-subheader">from your other device</small>{{/unsafeTranslate}}
</h1>
</header>

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div id="main-content" class="card pair-auth push-auth-complete">
<header>
<h1 id="push-auth-complete-header">{{#t}}Sign-in confirmed{{/t}}</h1>
<h1 id="push-auth-complete-header" class="card-header">{{#t}}Sign-in confirmed{{/t}}</h1>
</header>

<section>
Expand All @@ -11,4 +11,3 @@
<p class="verification-message">{{#t}}Please close this page and continue on the other device.{{/t}}</p>
</section>
</div>

Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div id="main-content" class="card">
<header>
<h1 id="{{headerId}}">{{{escapedHeaderTitle}}}</h1>
<h1 id="{{headerId}}" class="card-header">{{{escapedHeaderTitle}}}</h1>
</header>

<section>
Expand Down

0 comments on commit e490811

Please sign in to comment.