Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No graphic on on the "Approval now required" card at the end of the firefox.com/pair flow, #16080

Closed
dholbert opened this issue Nov 15, 2023 · 2 comments

Comments

@dholbert
Copy link

dholbert commented Nov 15, 2023

Description

In the QR-code-based https://firefox.com/pair flow, every single card has a colorful graphic, except for one -- the "Approval now required" card.

Steps to reproduce

(These are the exact same STR as #16079 -- this issue is about the same UI, but I'm just calling attention to a different problem in this issue.)

  1. In Firefox on Android, go to the Settings (from the 3-dot menu) and tap the Sync section at the top
  2. Tap "Ready to Scan" to open a QR-code-scanner.
  3. On your desktop Firefox (where you've set up with Firefox Sync), visit https://firefox.com/pair and click "Get Started"
  4. Scan the QR code.
  5. Click through the steps on your computer, until you get to the "Approval now required" card.

Expected result

Consistent look between that card and the rest of the cards in the flow. The card should have some sort of graphic (maybe representing "check your other device"), since all the other cards have a graphic.

Actual result

No graphic on this card. As a result, it looks a little spartan/lifeless, and loses some of the enthusiasm of the previous cards in the flow.

Environment

My desktop environment (where I'm seeing the card) is Firefox 121.0a1 (2023-11-13) on Ubuntu 22.04

Screenshot of the card in question (same screenshot as in #16079):
Screenshot from 2023-11-14 21-57-36

Here's a screenshot the previous card, for comparison (I'm pretty sure all of the other cards in the flow look similar to this one with a nice graphic):
Screenshot from 2023-11-14 21-57-30

┆Issue is synchronized with this Jira Task

@dholbert
Copy link
Author

CC @vpomerleau who might be interested, as it looks like she's been working on this flow in e490811 at least.

(It looks like the commit fixed the text-size issue but didn't add an image, which was the other thing that the associated Jira ticket https://mozilla-hub.atlassian.net/browse/FXA-8585 was focused on and is also what I happened to independently file this issue on here.)

@clouserw
Copy link
Member

clouserw commented Mar 1, 2024

Thanks for filing but this is not on our roadmap to fix at this point.

@clouserw clouserw closed this as not planned Won't fix, can't repro, duplicate, stale Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants