Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fxa-js-client] convert js-client unit tests to mocha #1857

Closed
vladikoff opened this issue Jul 19, 2019 · 2 comments · Fixed by #2039
Closed

[fxa-js-client] convert js-client unit tests to mocha #1857

vladikoff opened this issue Jul 19, 2019 · 2 comments · Fixed by #2039
Assignees
@vladikoff
Milestone
Train 144: FxA

Comments

@vladikoff
Copy link
Contributor

We should probably convert the current AMD Intern unit tests to mocha to match the rest of the repos.

(and later on even move the js-client directly into fxa-content-server, because it's not used anywhere else)
@shane-tomlinson
Copy link
Contributor

We should probably convert the current AMD Intern unit tests to mocha to match the rest of the repos.

👍 Love it.

@shane-tomlinson shane-tomlinson mentioned this issue Aug 1, 2019
Closed
@shane-tomlinson
Copy link
Contributor

intern-geezer is now causing security alerts because of old dependencies. :(

vladikoff added a commit that referenced this issue Aug 1, 2019
@vladikoff
refactor(js-client): convert fxa-js-client and its tests to commonjs
f1b0bcd 
* changes client structure
* moves to mocha

Fixes #1857
@vladikoff vladikoff mentioned this issue Aug 1, 2019
Merged
vladikoff added a commit that referenced this issue Aug 8, 2019
@vladikoff
refactor(js-client): convert fxa-js-client and its tests to commonjs
a310891 
* changes client structure
* moves to mocha

Fixes #1857
vladikoff added a commit that referenced this issue Aug 8, 2019
@vladikoff
refactor(js-client): convert fxa-js-client and its tests to commonjs
3b20139 
* changes client structure
* moves to mocha

Fixes #1857
vladikoff added a commit that referenced this issue Aug 8, 2019
@vladikoff
refactor(js-client): convert fxa-js-client and its tests to commonjs
55ea72e 
* changes client structure
* moves to mocha

Fixes #1857
vladikoff added a commit that referenced this issue Aug 9, 2019
@vladikoff
refactor(js-client): convert fxa-js-client and its tests to commonjs
f7d6775 
* changes client structure
* moves to mocha

Fixes #1857
vladikoff added a commit that referenced this issue Aug 12, 2019
@vladikoff
refactor(js-client): convert fxa-js-client and its tests to commonjs
60e07b5 
* changes client structure
* moves to mocha

Fixes #1857
@clouserw clouserw added this to the Train 144: FxA milestone Aug 16, 2019
@vbudhram vbudhram mentioned this issue Aug 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vladikoff vladikoff

Labels
None yet
Projects
None yet
Milestone
Train 144: FxA
Development

Successfully merging a pull request may close this issue.

refactor(js-client): convert fxa-js-client and its tests to commonjs mozilla/fxa
3 participants
@clouserw @vladikoff @shane-tomlinson