Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Train 145 into master #2419

Merged
merged 6 commits into from
Sep 6, 2019
Merged

Train 145 into master #2419

merged 6 commits into from
Sep 6, 2019

Conversation

vladikoff
Copy link
Contributor

No description provided.

@vladikoff
Copy link
Contributor Author

File so we don't forget, might need the point release commits in here as well

Copy link
Contributor

@shane-tomlinson shane-tomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

* support form: add subscription plan dropdown (bf89c002d)
* codes: Add the ux for signup codes (37929e13a)
* fortress: add "fortress" relying party (2ffe1334d)
- support form: add subscription plan dropdown (bf89c002d)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these changes were automatic and are consistent with the rest of the changelog.

@vladikoff
Copy link
Contributor Author

@shane-tomlinson r+

vbudhram and others added 2 commits September 5, 2019 14:59
…periment, r=@shane-tomlinson

chore(codes): Enable signup code sync experiment and enable for proxy
@bbangert
Copy link
Member

bbangert commented Sep 6, 2019

@vladikoff looks like you forgot to sign a commit in this.

@shane-tomlinson
Copy link
Contributor

@vladikoff looks like you forgot to sign a commit in this.

Aye, I didn't catch that since the original PR merged to train-145 instead of master.

@shane-tomlinson shane-tomlinson merged commit 881d757 into master Sep 6, 2019
@shane-tomlinson shane-tomlinson deleted the train-145 branch September 6, 2019 11:20
@shane-tomlinson shane-tomlinson restored the train-145 branch September 6, 2019 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants