feat(cwts): allow skipping the CWTS screen #2484
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladikoff
commented
Sep 12, 2019
packages/fxa-content-server/app/scripts/models/auth_brokers/oauth-webchannel-v1.js
Outdated
Show resolved
Hide resolved
|
Seems OK to me...capabilities are in general pretty ad-hoc so I'm not really able to suggest any clever alternatives here. |
|
As discussed in slack, I think this needs to default to |
vladikoff
force-pushed
the
skip-cwts
branch
from
1faa15f to
44652de
Compare
Say whaaa...? Is there something funky with the cherry-pick/rebase here @vladikoff? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @grigoryk @rfk feedback?
Fixes mozilla/application-services#1761
Kinda related to mozilla/application-services#1690