chore(ci): skip build & deploy of content-server docker image for PRs

[lmorchard]

TL;DR: This can possibly shave 10 whole minutes off CI times.

• split build & deploy out of test-content-server
• should still build & deploy for master branch and tagged releases

fixes #2526

[lmorchard]

Starting this as a draft to see how CircleCI likes it. Main thing here is to try saving the 6-8 minutes of building a Docker image for content-server that never gets used for tests or pushed anywhere.

[lmorchard]

Seems to work as expected on CircleCI - test-content-server is run, but build-and-deploy-content-server is not. However, I'm not entirely sure how to check its behavior for master branch and release tags without merging it. Maybe I can try hooking my personal fork up to CircleCI and merge to master there.

[lmorchard]

Turned on CircleCI for my personal fork of FxA and merged to master there. Good news is that the build-and-deploy job ran there. Bad news is that the deploy part did nothing, because my CircleCI setup doesn't have the credentials to actually try a push to Docker Hub. But I think that should work in the main repo.

Better news is that the build step took 10 minutes - which is roughly the sort of time that this PR should shave off CI runs for PRs in general.

[vladikoff]

@lmorchard please make sure that we can still deploy to docker using feature. and dockerpush. branches:

fxa/.circleci/deploy.sh

Line 11 in 8086820

if [[ "${CIRCLE_BRANCH}" == feature* ]] || [[ "${CIRCLE_BRANCH}" == dockerpush* ]]; then

[lmorchard]

Okay, pushed a tweak to include /feature.*/ and /dockerpush.*/ branches in triggering the build-and-deploy-content-server job.

No deploy job for 1234-foobar:

Yes deploy job for feature.foobar:

Yes deploy job for dockerpush.foobar:

[lmorchard]

Hmm, actually - I hadn't heard of this feature.* / dockerpush.* convention for branch names before now. We should probably document that somewhere.

But also, maybe I can push to one of those kinds of branches on the mozilla/fxa repo to test things out before actually going for a merge to master.

Edit: I tried it - hope I didn't blow anything up - but it seems to work with a dockerpush.* branch on mozilla/fxa:

[lmorchard]

Going to open this up for review. Seems like it's working, but could use some more eyes to surface anything else I might break like pushing to special branches.

[chenba]

👍

[lmorchard]

Going to merge... if this breaks anything, it should be pretty easy to revert 😅