Add X-Source-Tags to core AddMetadata headers list #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixup to #1328 since it looks like we have this logic duplicated in core and in beam.
jklukas
commented
Aug 3, 2020
ingestion-core/src/main/java/com/mozilla/telemetry/ingestion/core/transform/AddMetadata.java
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1329 +/- ##
============================================
- Coverage 85.04% 84.05% -1.00%
Complexity 681 681
============================================
Files 98 91 -7
Lines 4126 3869 -257
Branches 396 396
============================================
- Hits 3509 3252 -257
Misses 487 487
Partials 130 130
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
relud
approved these changes
Aug 3, 2020
relud
pushed a commit
that referenced
this pull request
Aug 3, 2020
Fixup to #1328 since it looks like we have this logic duplicated in core and in beam.
relud
pushed a commit
that referenced
this pull request
Aug 3, 2020
Fixup to #1328 since it looks like we have this logic duplicated in core and in beam.
relud
pushed a commit
that referenced
this pull request
Aug 3, 2020
Fixup to #1328 since it looks like we have this logic duplicated in core and in beam.
relud
pushed a commit
that referenced
this pull request
Aug 3, 2020
Fixup to #1328 since it looks like we have this logic duplicated in core and in beam.
ghost
reviewed
Apr 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixup to #1328 since it looks like we have this logic duplicated in core and in beam.