Skip to content

Commit

Permalink
Bug 1916774 [wpt PR 47965] - Require ::picker(select) appearance:base…
Browse files Browse the repository at this point in the history
…-select opt-in, a=testonly

Automatic update from web-platform-tests
Require ::picker(select) appearance:base-select opt-in

This patch requires that not only appearance:base-select be applied to
<select> to make the popup be a popover, but also for
appearance:base-select to be applied to select::picker(select). This is
being discussed here: w3c/csswg-drafts#10440

Change-Id: Ib089a9f8a4c0bea30d2f4fb9da1df185f4272db0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5819694
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1350885}

--

wpt-commits: c8fad8cf3d6e7fdc570048f03d9803d956060b2a
wpt-pr: 47965
  • Loading branch information
josepharhar authored and moz-wptsync-bot committed Sep 10, 2024
1 parent a9fcd25 commit 5432573
Show file tree
Hide file tree
Showing 6 changed files with 21 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,13 @@
<script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-vendor.js"></script>

<select style="appearance:base-select">
<style>
select, select::picker(select) {
appearance: base-select;
}
</style>

<select>
<option></option>
</select>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<script src="/resources/testdriver-vendor.js"></script>

<style>
select {
select, select::picker(select) {
appearance: base-select;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<script src="/resources/testdriver-actions.js"></script>

<style>
select {
select, select::picker(select) {
appearance: base-select;
}
</style>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<script src="/resources/testdriver-actions.js"></script>

<style>
select {
select, select::picker(select) {
appearance: base-select;
}
</style>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,13 @@
color: SelectedItemText;
background-color: SelectedItem;
}
select, select::picker(select) {
appearance: base-select;
}
</style>
<div id=selecteditem>SelectedItem test colors</div>

<select style="appearance:base-select">
<select>
<option class=one>one</option>
<option class=two>two</option>
<option class=three disabled>disabled</option>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,14 @@
<script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-vendor.js"></script>

<style>
select, select::picker(select) {
appearance: base-select;
}
</style>

<form>
<select style="appearance:base-select">
<select>
<button>
<selectedoption></selectedoption>
</button>
Expand Down

0 comments on commit 5432573

Please sign in to comment.