-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot set proxy to geckodriver 0.16 #669
Comments
Can you supply the Selenium client version? Language binding? Trace-level log from geckodriver? |
@andreastt Sure. selenium-java 3.4.0 Below is the full log:
|
@asolntsev Hm, unfortunately that’s only the debug-level logs. Try passing |
@andreastt I am getting the same output after adding |
@asolntsev No, I’m not able to reproduce this. Is this still an issue on Firefox Nightly? I can’t really tell what’s wrong unless you attach a geckodriver trace log. Apparently, if you’re using Java, you can use the |
same error here, we get this while working with embedded selenium server process and trying to get the driver object Our setup: Trace:
|
@shyoro That log isn’t particularly helpful since you didn’t add any of the information I requested in #669 (comment). It would be useful if you tried this with the most recent Firefox Nightly and Selenium versions. |
Any Updates on this one? |
Closing due to inactivity. Happy to reopen when a trace-level log has been added. Without this we’re unable to diagnose the issue. |
@andreastt Here are some trace-level logs: 1495475878949 geckodriver INFO Listening on 127.0.0.1:10091 org.openqa.selenium.SessionNotCreatedException: InvalidArgumentError: Expected [object Undefined] undefined to be an integer |
@asolntsev can you repoen this please, given above trace-level logs. |
@wfloutier I cannot re-open the issue that was closed by a repo collaborator. |
It looks like this is happening in Marionette for the following line:
The above trace log doesn't list this property and as such we fail. I wonder if this should be handled as optional. @andreastt can you please check? A workaround might be to just add a valid version for the socks proxy into the capabilities. |
@whimboo @andreastt What would have been the behavior if the socksProxy/socksProxyPort hadn't been set at all? For that matter, what would be the behavior if only a single type of proxy was set - e.g. FTP and no others? |
@whimboo I still see this issue even if I set a fake socks proxy. |
I'm experiencing this issue as well and might have logged an identical issue #762. If it is, then I'll close it. |
Just to chip in here, I have the same problem using RemoteWebDriver - I've worked around it by manually setting the proxy configuration on the FirefoxProfile object as follows -
Unlike @asolntsev's workaround, I've had to set the proxy type to manual, and the ports have to be integers to be overridden in about:config (although I'm not sure if that's just a side effect of using RemoteWebDriver). |
I'm using the Docker container selenium/node-firefox-debug:3.4.0-einsteinium as the browser, and I'm using Java with selenium-java 3.4.0. |
Any updates about this issues? any ETA? |
I have the same issue too. I have the latest Firefox and geckodriver installed. Can someone please help? Firefox: 54.0.1 ProfilesIni profile = new ProfilesIni(); DesiredCapabilities capabilities = new DesiredCapabilities(); System.setProperty("webdriver.firefox.bin",Config.Path_Firefox); I get the following error |
I think the problem is the Proxy, because when I using JSONObject to pass the parameter |
Confirmed in latest geckodriver (0.18.0), Firefox 54.0.1 and Selenium 3.4.0. The language bindings are https://github.com/facebook/php-webdriver/, however, the POST parameters send to Selenium server when creating the session are: {"desiredCapabilities":{"browserName":"firefox","platform":"ANY","proxy":{"proxyType":"MANUAL","httpProxy":"proxy.foo.bar","httpProxyPort":8118,"sslProxy":"proxy.foo.bar","sslProxyPort":8118}}} So from the language bindings point of view there is nothing wrong with the integer in the port number... |
Also I want to note that the correct property name is "socksVersion", and its type is string, accoring to the spec, see https://www.w3.org/TR/webdriver/#proxy |
Just a small nit: the |
Oh! Thanks! Yes, in ED it has numeric type. |
Everyone please note that I started to make changes in how geckodriver/Marionette is handling proxies. There is a lot of work to do but soon I will also get started to get rid of this extra port property, and make it conforming the webdriver specs. The work will be done on bug 1369827 So if you want to see where we are, please have a look at this bug. We don't need more 'me too' comments here. Thanks. |
With gecko driver 18.0 and firefox 55.0.1 also having the same issue below is the tracelog: |
@prasanna532 this is most likely because you are using a socks proxy, right? It will also be fixed with the bug I pointed out above. |
@whimboo Can this be closed? |
Not yet. The original comment on this issue is exactly what I work on right now via bug 1369827 as stated above 11 days ago. |
Actually lets mark as dupe of issue #764 which has a more in depth explanation of the problem. |
This issue has been automatically locked since there has not been any recent activity after it was closed. If you have run into an issue you think is related, please open a new issue. |
Firefox Version
53.0
Selenium version
selenium-java 3.4.0
Platform
OSX
Steps to reproduce -
Create a
FirefoxDriver
instance withProxy
:it throws the following exception:
P.S. Adding proxy in this way doesn't throw an exception:
The text was updated successfully, but these errors were encountered: