Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-emphasize inactive probes in search results #1125

Closed
mstange opened this issue Jan 21, 2021 · 2 comments
Closed

De-emphasize inactive probes in search results #1125

mstange opened this issue Jan 21, 2021 · 2 comments

Comments

@mstange
Copy link

mstange commented Jan 21, 2021

I was using the search field in GLAM to find probes about GC pause times, and one of the top results showed me an inactive probe without any data.

Steps to reproduce:

  1. Go to https://glam.telemetry.mozilla.org/.
  2. Enter "gc pause" in the search field.

Expected results:
I should see the most relevant results first. In this case this would be "gc_max_pause_ms_2". Active probes should be ranked higher than inactive probes, and ideally the search result list should be annotated with "active" / "inactive".

Actual results:
At the moment, number 1 is "cycle_collector_max_pause", and number 2 is "gc_max_pause_ms".
"cycle_collector_max_pause" is somewhat related, but CC is strictly speaking not GC.
More importantly, "gc_max_pause_ms" is an inactive probe and doesn't show any data.
Its replacement, "gc_max_pause_ms_2", is at the bottom of the list.

@mstange
Copy link
Author

mstange commented Jan 21, 2021

The same happens if you search for "delay". The first five results (which take up 75% of the search result screen estate) are all inactive probes without data.

@wlach
Copy link
Contributor

wlach commented Jan 26, 2021

Note that "inactive" actually means "expired" in the case mentioned: https://probes.telemetry.mozilla.org/?search=gc_max_pause_ms&view=detail&probeId=histogram%2FGC_MAX_PAUSE_MS

I.e. we're not collecting any data for this, and haven't been for quite some time.

robhudson added a commit that referenced this issue Jan 28, 2021
Also tweak search SQL query to include all terms.

Fixes #1125, 1138
robhudson added a commit that referenced this issue Jan 28, 2021
Also tweak search SQL query to include all terms.

Fixes #1125, 1138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants