Fix #216: Use OptionMenu for large category sets

[openjck]

No description provided.

[hamilton]

Looking good @openjck – left a few comments to address.

I am noticing that the alignment of these menu items are a bit off. The icon & swatch align, but the number looks like it is not aligned with the rest. Is this something that is addressable here in GLAM? If not, then we should re-create this use-case in graph-paper in storybook to make sure it works as expected.

There is a merge conflict here that will need to be addressed, but that should be straightforward.

[openjck]

I am noticing that the alignment of these menu items are a bit off.

That's a quick fix in graph-paper. I'll submit a PR to address that now. I don't think we need to block merging this PR on that, but we will get the alignment fixed for free once optionmenu is upgraded.

[openjck]

Here's the graph-paper PR:

graph-paper-org/graph-paper#148

[hamilton]

Thanks for the changes. I made one suggestion about the color choice. 400 feels very dark, and 300 would probably suffice here.

Is there any wy we can have the colored buckets (which are the ones with more counts than the others) at the top of the sortedInactiveBuckets list? As it is now, I clicked on one then had to scroll far to find it again. I think this is a pretty quick change, since you can just keep the inactive buckets with color assignemnts toward the top of that list.

If those makee sense, feel free to make those changes and merge at your discretion. Thanks!

[hamilton]

suggested changes in previous comment