Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1742613 - Remove deprecated headers from Glean pings #1046

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Bug 1742613 - Remove deprecated headers from Glean pings #1046

merged 2 commits into from
Jan 17, 2022

Conversation

brizental
Copy link
Contributor

@brizental brizental commented Dec 20, 2021 •
edited
Loading

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/ folder, run:
      • npm run test Runs all tests
      • npm run lint Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work

@auto-assign auto-assign bot requested a review from Dexterp37 December 20, 2021 15:13
Dexterp37
Dexterp37 approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ but please rebase before merging

CHANGELOG.md Show resolved Hide resolved
@brizental brizental force-pushed the 1742613-remove-headers branch from 955505a to 2aae42a Compare January 17, 2022 14:38
@brizental brizental merged commit 4406afb into mozilla:main Jan 17, 2022
@brizental brizental deleted the 1742613-remove-headers branch January 17, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dexterp37 Dexterp37 Dexterp37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brizental @Dexterp37