-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose a "glean" command #105
Conversation
This exposes a "glean" command to be used as an interface for running the glean_parser by glean.js consuming products. It takes care of setting up a virtual environment and making sure that the parser and its dependencies are up to date.
Tested on MacOS and it works. Let's file a follow up for showing some status, specially the first run takes a long long time and it looks like it's frozen. Can you send commits with changes to the sample extensions? Currently they rely on a globally installed glean_parser. |
I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1699391 and https://bugzilla.mozilla.org/show_bug.cgi?id=1699392 as potential follow-up work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+wc. This is great.
This exposes a "glean" command to be used as an interface for running the glean_parser by glean.js
consuming products. It takes care of setting up a virtual environment and making sure that the parser
and its dependencies are up to date.
How to test this:
npm link
npx glean ....
and check the generated output.For rally, I had this output:
TODO:
Add unit tests?(we're not going to add them, but instead we're adding this command to the samples)