Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1746375 - Expose testResetGlean on a standalone endpoint #1071

Closed
wants to merge 2 commits into from
Closed

Bug 1746375 - Expose testResetGlean on a standalone endpoint #1071

wants to merge 2 commits into from

Conversation

brizental
Copy link
Contributor

One more thing to leave out of the bundle. The size difference is kinda small compared to #1065 and #1051 but I think this is a nice change so there we have it.

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/ folder, run:
      • npm run test Runs all tests
      • npm run lint Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work

@auto-assign auto-assign bot requested a review from Dexterp37 January 4, 2022 16:21
@moz-glean
Copy link
Collaborator

Build size report

Merging #1071 into main will:

  • Decrease the size of full Web Extension bundle build by -1%.
  • Decrease the size of full Website bundle build by -1%.
  • Leave the size of full Node.js bundle unchanged.
  • Leave the size of full Qt/QML bundle unchanged.
Current size New size Size increase
Web Extension
core only 67 KB 66 KB 📉 1.5 KB
full bundle 89 KB 88 KB 📉 1.4 KB
Website
core only 68 KB 67 KB 📉 1.4 KB
full bundle 90 KB 89 KB 📉 1.4 KB
Node.js
core only 66 KB 65 KB 📉 563 bytes
full bundle 94 KB 94 KB 📉 563 bytes
Qt/QML
core only 70 KB 70 KB 📉 154 bytes
full bundle 70 KB 70 KB 📉 154 bytes

@brizental
Expose testResetGlean on a standalone endpoint
2422ae2 
This way it is not part of Glean.js and is only added to the Glean
bundle when in fact used. Since it is supposed to only be used in tests,
I guess should never even be part of the bundle.
@brizental
Update samples code to use new testResetGlean API endpoint
ef15cb9
@brizental brizental force-pushed the 1746375-leave-testing-out branch from 38be63d to ef15cb9 Compare January 11, 2022 09:22
Dexterp37
Dexterp37 requested changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits. Would you kindly add a changelog entry? this is "kind of a breaking change".

glean/src/core/testing/index.ts
import { testInitializeGlean, testUninitializeGlean } from "./utils.js";

/**
* Test-only API**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Test-only API**
* **Test-only API**

Copy link
Contributor Author

@brizental brizental Jan 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter takes there extra asterisks out and complains if they are there... Please don't be offended if I ignore these suggestions, BLAME THE LINTER.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, don't worry :-) Then would you kindly remove the trailing ** as well? They don't make much sense :)

glean/src/core/testing/utils.ts
import Glean from "../glean.js";

/**
* Test-only API**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Test-only API**
* **Test-only API**

glean/src/core/testing/utils.ts
}

/**
* Test-only API**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Test-only API**
* **Test-only API**

@brizental
Copy link
Contributor Author

Some minor nits. Would you kindly add a changelog entry? this is "kind of a breaking change".

Ack, good catch. I'd say this is 100% a breaking change... Why do you always review the PRs where I forgot to add the changelog?! I swear I never forget on the other ones!!11!

@Dexterp37
Copy link
Contributor

Some minor nits. Would you kindly add a changelog entry? this is "kind of a breaking change".

Ack, good catch. I'd say this is 100% a breaking change... Why do you always review the PRs where I forgot to add the changelog?! I swear I never forget on the other ones!!11!

You never forget to add these... until you do. And I'm there 👁️_👁️ . Lurking in the shadows.Waiting for this to happen. (ok, creepyness over)

@brizental brizental closed this Jan 17, 2022
@brizental brizental deleted the 1746375-leave-testing-out branch January 17, 2022 15:18
@brizental
Copy link
Contributor Author

Reopened in #1096.

Deleted the branch by mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dexterp37 Dexterp37 Dexterp37 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brizental @moz-glean @Dexterp37