Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1749301 - Do not clear app lifetime metrics if sending deletion-request ping on init #1077

Merged
merged 2 commits into from
Jan 10, 2022

Conversation

brizental
Copy link
Contributor

@brizental brizental commented Jan 10, 2022

This is how deletion-request pings were looking like before the fix.

 (Glean.core.Pings.Maker) {
  "ping_info": {
    "seq": 0,
    "start_time": "2022-01-10T14:36+01:00",
    "end_time": "2022-01-10T14:36+01:00"
  },
  "client_info": {
    "telemetry_sdk_build": "0.29.0",
    "client_id": "da8d1774-2704-4828-ac4c-e2949f55d887",
    "first_run_date": "2022-01-10+01:00"
  }
}

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/ folder, run:
      • npm run test Runs all tests
      • npm run lint Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work

@auto-assign auto-assign bot requested a review from Dexterp37 January 10, 2022 14:19
@brizental brizental changed the title Do not clear app lifetime metrics if sending deletion-request ping on init Bug 1749301 - Do not clear app lifetime metrics if sending deletion-request ping on init Jan 10, 2022
@brizental brizental requested review from badboy and removed request for Dexterp37 January 10, 2022 14:23
Copy link
Member

@badboy badboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nasty one. kudos for finding and fixing that.

@brizental brizental merged commit 4b90928 into mozilla:main Jan 10, 2022
@brizental brizental deleted the 1749301-init-del-pings branch January 10, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants