-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1690253 - Implement the 'events' ping #1267
Conversation
..And more coreMetrics as well because it makes sense.
startup: | | ||
The ping was submitted at startup. | ||
The events ping is always sent if there are any pending events at startup, | ||
because event timestamps are not as reliable across application runs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We did not discuss in the bug, but I thought it made sense to also include the startup trigger for sending the events ping as well as the max_capacity.
The events ping is always sent if there are any pending events at startup, | ||
because event timestamps are not as reliable across application runs. | ||
max_capacity: | | ||
The maximum number of events was reached (default 500 events). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Different from the other SDKs, max capacity will only apply for the 'events' ping as discussed in this proposal.
Co-authored-by: Jan-Erik Rediger <badboy@archlinux.us>
Pull Request checklist
glean/
folder, run:npm run test
Runs all testsnpm run lint
Runs all lintersCHANGELOG.md
or an explanation of why it does not need one