Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1690253 - Implement the 'events' ping #1267

Merged
merged 6 commits into from
Mar 17, 2022

Conversation

brizental
Copy link
Contributor

@brizental brizental commented Mar 16, 2022

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/ folder, run:
      • npm run test Runs all tests
      • npm run lint Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work

Comment on lines +45 to +48
startup: |
The ping was submitted at startup.
The events ping is always sent if there are any pending events at startup,
because event timestamps are not as reliable across application runs.
Copy link
Contributor Author

@brizental brizental Mar 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did not discuss in the bug, but I thought it made sense to also include the startup trigger for sending the events ping as well as the max_capacity.

The events ping is always sent if there are any pending events at startup,
because event timestamps are not as reliable across application runs.
max_capacity: |
The maximum number of events was reached (default 500 events).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different from the other SDKs, max capacity will only apply for the 'events' ping as discussed in this proposal.

@brizental brizental requested review from Dexterp37 and badboy March 16, 2022 17:23
glean/src/core/config.ts Outdated Show resolved Hide resolved
@Dexterp37 Dexterp37 requested review from badboy and removed request for Dexterp37 March 17, 2022 10:23
glean/src/core/config.ts Outdated Show resolved Hide resolved
glean/src/core/config.ts Outdated Show resolved Hide resolved
glean/src/core/metrics/events_database/index.ts Outdated Show resolved Hide resolved
glean/src/core/metrics/events_database/index.ts Outdated Show resolved Hide resolved
glean/src/core/upload/manager.ts Outdated Show resolved Hide resolved
Co-authored-by: Jan-Erik Rediger <badboy@archlinux.us>
@brizental brizental merged commit ee00a7a into mozilla:main Mar 17, 2022
@brizental brizental deleted the 1690253-events-ping branch March 17, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants