Fix ts-node version issue with webext sample project #1457
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I discovered that the
webext
tests were broken with newer versions of node. This is the same issue that we saw with the main glean package tests. I did not realize at first that this sample project also had its own tests and the same issues as the glean tests. The same fix that we did for glean proper can be applied here.Notes on the other sample projects tests
web
- This project does not have tests, so there is nothing to fix.node
- This project usesmocha
directly for testing, it does not do any of the experimental ESM stuff likeglean
&webext
qt
- The tests for this project has issues, but they are not related to thets-node
versions. I am logging a bug for those to be worked on separately.Testing
npm run test
from inside of thesamples/browser/webext
folder with a node version greater than10.5.x
.Pull Request checklist
glean/
folder, run:npm run test
Runs all testsnpm run lint
Runs all lintersCHANGELOG.md
or an explanation of why it does not need onemozilla/glean
repository