Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building on Windows #1671

Merged
merged 2 commits into from
May 10, 2023
Merged

Fix building on Windows #1671

merged 2 commits into from
May 10, 2023

Conversation

Dexterp37
Copy link
Contributor

Yes, this brings in a new dev dependency, but this additionally makes it possible to build on Windows, which was not possible before due to platform-specific dir deletion code.

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/ folder, run:
      • npm run test Runs all tests
      • npm run lint Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work

@Dexterp37 Dexterp37 requested a review from badboy May 10, 2023 08:48
@Dexterp37 Dexterp37 self-assigned this May 10, 2023
@auto-assign auto-assign bot requested a review from chutten May 10, 2023 08:48
@Dexterp37 Dexterp37 removed the request for review from chutten May 10, 2023 08:50
@Dexterp37 Dexterp37 merged commit 994a8bb into mozilla:main May 10, 2023
@Dexterp37 Dexterp37 deleted the fix_windows_build branch May 10, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants