Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1700578 - Drop Node.js support from webext build #173

Merged
merged 2 commits into from
Apr 7, 2021
Merged

Bug 1700578 - Drop Node.js support from webext build #173

merged 2 commits into from
Apr 7, 2021

Conversation

brizental
Copy link
Contributor

No description provided.

@brizental brizental requested a review from Dexterp37 April 6, 2021 13:29
Dexterp37
Dexterp37 approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Before merging, would you kindly make sure this doesn't break bergamot and rally?

@Dexterp37
Copy link
Contributor

@brizental would you also kindly add a changelog entry?

@brizental
Copy link
Contributor Author

LGTM. Before merging, would you kindly make sure this doesn't break bergamot and rally?

Tried with a linked package and it didn't break anything new 😅

@brizental brizental merged commit aed7911 into mozilla:main Apr 7, 2021
@brizental brizental deleted the 1700578-only-browser branch April 7, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dexterp37 Dexterp37 Dexterp37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brizental @Dexterp37