Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1851698 - Update default maxEvents to 1 #1766

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

rosahbruno
Copy link
Contributor

@rosahbruno rosahbruno commented Sep 5, 2023

Docs update mozilla/glean#2611

changelog

  • set the default maxEvents number to 1
  • update existing tests that rely on having more than 1 event
  • update comments in pings.yaml

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/ folder, run:
      • npm run test Runs all tests
      • npm run lint Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work

changelog
- set the default `maxEvents` number to 1
- update existing tests that rely on having more than 1 event
- update comments in `pings.yaml`
@rosahbruno rosahbruno force-pushed the 1851698-update-max-events branch from 8fb3d66 to f7363ca Compare September 5, 2023 21:21
@rosahbruno rosahbruno marked this pull request as ready for review September 6, 2023 19:55
@rosahbruno rosahbruno requested review from a team and travis79 and removed request for a team September 6, 2023 20:40
Copy link
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but you might want to update the Glean docs and note the difference here with Glean.js in the limits section of the EventMetric here: https://mozilla.github.io/glean/book/reference/metrics/event.html#limits

@rosahbruno
Copy link
Contributor Author

@travis79
Good callout, I updated this in the other PR - mozilla/glean@9956a3f

@rosahbruno rosahbruno requested a review from travis79 September 7, 2023 16:18
Copy link
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs!

@rosahbruno rosahbruno merged commit 9c1600f into mozilla:main Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants