Bug 1701578 - Remove more circular dependencies #184
Conversation
This removes the direct dependency on Glean.ts. There's still an indirect dependency on that due to the metric types.
This removes a circular dependency and eases further removal of the remaining circular dependencies.
This removes a fake circular dependency related to the 'uuid' package imported via NPM.
This makes sure Glean.ts isn't mistakenly imported, as a circular dependency, when it's not strictly needed.
Importing as a type is available since TS 3.8 and allows to import types that are exclusively used for annotations and removed after the build. This additionally changes the Madge configuration to not complain when type imports are used. See pahen/madge#232
For example, in places like this one, we import the file but are exclusively interested to the internal metric, not the type. This file is further included in many chains that end up in the Glean.ts include line. |
So, basically, put as little exports as possible in any files that include a |
By splitting we are actually guaranteeing that the e.g. 'datetime_metric.ts' file, included in many places, does not include Glean.ts at all: so utils.ts won't require Glean.ts at all! |
This is a big PR, sorry. However, it's fairly well split across commits and takes down the detected circular dependencies from 17 to ....
We're almost there!