Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1862955 - fix browserstack session tests #1877

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

rosahbruno
Copy link
Contributor

This is a followup to #1850. The changes in that PR broke the browserstack tests. This updates our browserstack tests to rely on data from LocalStorage rather than trying to pull session IDs from log messages.

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/ folder, run:
      • npm run test Runs all tests
      • npm run lint Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work
  • Documentation should be added to The Glean Book when making changes to Glean's user facing API
    • When changes to the Glean Book are necessary, link to the corresponding PR on the mozilla/glean repository
  • Documentation should be added to the Glean.js developer documentation when making internal code changes

@auto-assign auto-assign bot requested a review from badboy February 29, 2024 00:25
@Dexterp37 Dexterp37 requested review from travis79 and removed request for badboy February 29, 2024 07:44
@rosahbruno rosahbruno force-pushed the 1862955-session-fix branch from 30c58f7 to 253f276 Compare March 1, 2024 14:28
@rosahbruno rosahbruno merged commit d5ec750 into mozilla:main Mar 1, 2024
5 of 6 checks passed
@rosahbruno rosahbruno deleted the 1862955-session-fix branch March 1, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants