Bug 1706255 - Fix Qt sample and Qt CI check #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brizental
force-pushed
the
1706255-fix-qt
branch
2 times, most recently
from
8a482f9 to
a6e77e5
Compare
brizental
force-pushed
the
1706255-fix-qt
branch
from
a6e77e5 to
79e9d5e
Compare
|
Ok this is ready for review, it fixes with the Qt sample and "Oh, but the check is red!" -- Indeed, but the check is red because there is another issue on the CI check that is failing to install Qt properly. You will need to take my word that the sample is working, but to give a bit more confidence, here is a video of it working: qt.movI would like to get this merged before I work on the dependencies issue in CI check, because I would not like to block the other fixes (which are more important) on it. |
brizental
commented
Apr 20, 2021
brizental
force-pushed
the
1706255-fix-qt
branch
from
79e9d5e to
2f46772
Compare
Dexterp37
reviewed
Apr 20, 2021
This check did not account for errors other than Glean errors i.e. import errors.
brizental
force-pushed
the
1706255-fix-qt
branch
from
fe71d16 to
bfbf60b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI check did not account for errors other than Glean errors i.e. import errors.
Opening this as a draft to check that CI now does fail (as the sample is broke, it cannot import Glean at the moment).