Bug 1706103 - Add step to relase Qt build in Publish CI script #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dexterp37
reviewed
Apr 20, 2021
Dexterp37
approved these changes
Apr 20, 2021
brizental
force-pushed
the
1706103-qt-release
branch
from
bd7415c to
65e78dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I copied the way the Glean SDK does it and also how it names the final file. I tested this locally and it worked, I added a Qt asset to the 0.9.2 with the loca test, see https://github.com/mozilla/glean.js/releases/tag/v0.9.2.
(self reminder: For this to work I need to add a
GITHUB_TOKENenv var to CircleCI).