Bug 1694770 - Implement the timespan metric type #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dexterp37
requested changes
Apr 27, 2021
Yes, we were only missing labeled. Unless we introduce a metric type that the Glean SDK does not also support, we are good. |
brizental
force-pushed
the
1694770-timespan
branch
from
b689d9e to
4dbef01
Compare
Dexterp37
approved these changes
Apr 28, 2021
| * No error is recorded if no `start()` was called. | ||
| */ | ||
| cancel(): void { | ||
| Context.dispatcher.launch(() => { |
There was a problem hiding this comment.
Why wasn't this failing our tests? did you end up finding out?
There was a problem hiding this comment.
Dispatched or not, start and cancel when called in sequence seem to run one after the other. Probably because neither have any actual await inside. I tried to make the tests fail, but they never did.
Only when I launch some setTimeout's in between calling them do they fail, but I did not commit such a test because I thought it would be confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.