Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1712080 - Gzip ping paylod before upload #415

Merged
merged 6 commits into from
Jun 15, 2021

Conversation

brizental
Copy link
Contributor

@brizental brizental commented Jun 14, 2021

Should I file a bug to document that pings are gzipped? I looked and that is not mentioned on the Glean book. That could be important for folks using custom uploaders for testing, but that could also be behaviour we want to disencourage... Even if we don't disencourage it, we might want to expose the WaitableHttpClient in the future. Then people still don't need to worry about gzipping.

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/folder, run:
      • npm run test Runs all tests
      • npm run lint && npm run lint:circular-deps Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work

@brizental brizental changed the title 1712080 gzip Bug 1712080 - Gzip ping paylod before upload Jun 14, 2021
@brizental brizental requested a review from Dexterp37 June 14, 2021 14:03
Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you kindly do, if you didn't already, a test with the debug view (before merging)?

@brizental
Copy link
Contributor Author

Would you kindly do, if you didn't already, a test with the debug view (before merging)?

https://debug-ping-preview.firebaseapp.com/pings/gzipped-webext Did that while developing, ignore the failing one that was just development.

@brizental brizental merged commit 9a2d988 into mozilla:main Jun 15, 2021
@brizental brizental deleted the 1712080-gzip branch June 15, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants