Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no bug] Record the events timestamp before dispatching #431

Merged
merged 4 commits into from
Jun 17, 2021
Merged

[no bug] Record the events timestamp before dispatching #431

merged 4 commits into from
Jun 17, 2021

Conversation

Dexterp37
Copy link
Contributor

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/folder, run:
      • npm run test Runs all tests
      • npm run lint && npm run lint:circular-deps Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work

Dexterp37 added 3 commits June 17, 2021 10:52
@Dexterp37
BONUS: Report the correct type for seq
b2fceb3
@Dexterp37
Record the event timestamp before dispatching
d0b9d75 
Recording the timestamp in a dispatched function
could potentially delay its recording and provide
inaccurate timestamps.
@Dexterp37
Fix a typo
d716f80
@Dexterp37 Dexterp37 self-assigned this Jun 17, 2021
@Dexterp37 Dexterp37 requested a review from brizental June 17, 2021 14:50
@Dexterp37 Dexterp37 merged commit 9885dc9 into mozilla:main Jun 17, 2021
@Dexterp37 Dexterp37 deleted the events_tresh branch June 17, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brizental brizental brizental approved these changes

Assignees

@Dexterp37 Dexterp37

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dexterp37 @brizental