Bug 1714365 - Expose ErrorType enum #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One very important change in this commit, aside from the obvious change of adding a command we expected to be there but wasn't "test", is adding "strip-ansi" as a development dependency. That is a not a dependecy used by the sample, it is a dependency used by dependencies of the sample. It is needs to be explicitly declared in our dependencies to make sure the ESM version of that library is loaded. Otherwise the CJS dependency is downloaded causes compatibility issues.
We use --prefix a lot on the CI and that makes link behave differently. Using the same strategy as in benchmarks, we make sure both linking steps happen with the same prefix and thus the linking works as expected. This will fix Bug 1707626.
badboy
approved these changes
Jul 5, 2021
Indeed, sorry about that 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation PR: mozilla/glean#1705
Pull Request checklist
glean/folder, run:npm run testRuns all testsnpm run lint && npm run lint:circular-depsRuns all lintersCHANGELOG.mdor an explanation of why it does not need onemozilla/gleanrepository